[Webkit-unassigned] [Bug 131567] Need WK2 API to disable rubber-banding

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131567


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229171|review?                     |review+
               Flag|                            |




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-04-11 16:16:10 PST ---
(From update of attachment 229171)
View in context: https://bugs.webkit.org/attachment.cgi?id=229171&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.h:185
> +WK_EXPORT bool WKPageVerticalRubberBandingIsDisabled(WKPageRef);
> +WK_EXPORT void WKPageDisableVerticalRubberBanding(WKPageRef, bool disableVerticalRubberBanding);
> +WK_EXPORT bool WKPageHorizontalRubberBandingIsDisabled(WKPageRef);
> +WK_EXPORT void WKPageDisableHorizontalRubberBanding(WKPageRef, bool disableHorizontalRubberBanding);

It would be slightly cleaner to have the API in positive terms (enabled, not disabled) I think.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:363
> +    void disableVerticalRubberBanding(bool);
> +    void disableHorizontalRubberBanding(bool);

I think setDisabled would be better terminology (or setEnabled if you want a positive term).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.