[Webkit-unassigned] [Bug 131553] Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131553


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #229173|review?                     |review-
               Flag|                            |




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-04-11 16:09:59 PST ---
(From update of attachment 229173)
View in context: https://bugs.webkit.org/attachment.cgi?id=229173&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:604
> +bool HTMLPlugInImageElement::isTopLevelFullPage(const RenderEmbeddedObject& renderEmbedded, int contentWidth, int contentHeight)

Fewer weird abbreviations please!
isTopLevelFullPagePlugin(const RenderEmbeddedObject& embeddedObject, ...

> Source/WebCore/html/HTMLPlugInImageElement.cpp:606
> +    if (document().frame()->isMainFrame()) {

if (!document().frame()->isMainFrame())
  return false

> Source/WebCore/html/HTMLPlugInImageElement.cpp:613
> +        if (isFullPage && contentArea > visibleArea * sizingFullPageAreaRatioThreshold)
> +            return true;

return isFullPage && (contentArea > visibleArea * sizingFullPageAreaRatioThreshold);

> Source/WebCore/html/HTMLPlugInImageElement.cpp:622
> +    if (contentWidth <= sizingTinyDimensionThreshold || contentHeight <= sizingTinyDimensionThreshold)
> +        return true;
> +    return false;

return (contentWidth <= sizingTinyDimensionThreshold || contentHeight <= sizingTinyDimensionThreshold)

This could be a local static function.

> Source/WebCore/html/HTMLPlugInImageElement.cpp:630
> +        auto& renderEmbedded = toRenderEmbeddedObject(*this->renderer());

Why not use the renderEmbeddedObject() function (and check its return value)?

> Source/WebCore/html/HTMLPlugInImageElement.cpp:642
> +        if (displayState() == Playing)
> +        checkSizeChangeForSnapshotting();

Wrong indentation.

> Source/WebCore/html/HTMLPlugInImageElement.h:144
> +    bool isTopLevelFullPage(const RenderEmbeddedObject&, int contentWidth, int contentHeight);

Should be a const function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.