[Webkit-unassigned] [Bug 131553] Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 11 13:17:22 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=131553





--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-04-11 13:17:41 PST ---
(From update of attachment 229149)
View in context: https://bugs.webkit.org/attachment.cgi?id=229149&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:620
> +            auto& style = renderEmbedded.style();
> +            bool isFullPage = is100Percent(style.width()) && is100Percent(style.height());
> +            IntSize visibleViewSize = document().frame()->view()->visibleSize();
> +            float contentArea = contentWidth * contentHeight;
> +            float visibleArea = visibleViewSize.width() * visibleViewSize.height();
> +            if (isFullPage && contentArea > visibleArea * sizingFullPageAreaRatioThreshold) {

You should share this code with HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list