[Webkit-unassigned] [Bug 131553] New: Snapshotted plugins may need to be restarted if style properties are changed after initial load of plugin.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131553

           Summary: Snapshotted plugins may need to be restarted if style
                    properties are changed after initial load of plugin.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: roger_fong at apple.com
                CC: simon.fraser at apple.com, dino at apple.com,
                    jonlee at apple.com, thorton at apple.com


When looking at the method subframeLoaderWillCreatePlugin you'll notice that the state of the plugin sometimes can depend on the style.
The style can change at any point. It can also be resolved after the initial load of the plugin, which could cause a plugin to be snapshotted when it shouldn't be.

For example, consider a plugin that is styled to be 1x1. 
The 1x1 plugin should never be snapshotted but if the style isn't resolved before the initial load of the plugin we assume the default RenderReplaced size for the plugin (300 x 150).
A plugin at this size will indeed get snapshotted. Thus we end up with a 1x1 plugin that is snapshotted.

When performing postLayoutTasks we checkSnapshotStatus. 
I think this would be a good place to also check to see if the style conditions are met.
If they are and the plugin is currently snapshotted then we should restart the plugin so that it actually runs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.