[Webkit-unassigned] [Bug 125558] wk2-gtk does not display anything

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125558





--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-04-11 05:28:59 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > Hi all,
> > 
> > Several attempts and a dozen patches later I finally got trunk to build on FreeBSD in debug mode.
> > 
> > The problem seems to come from a call to fcntl(2) that fails with EOPNOTSUPP. From Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:
> > 
> >     while (fcntl(duplicatedHandle, F_SETFD, FD_CLOEXEC) == -1 || fcntl(duplicatedHandle, F_SETFL, accessModeFile(protection)) == -1) {
> > 
> > The second fcntl() call fails and nothing is displayed (in debug mode WebProcess crashes because of the ASSERT_NOT_REACHED() below those calls).
> 
> Thanks for debugging this. It seems that call is also wrong in linux, according to the fcntl man page the only flags allowed are O_APPEND, O_NONBLOCK, O_ASYNC and O_DIRECT, but I guess in linux it ignores the open flags instead of failing. In any case, a file descriptor duplicated with dup has the same flags of the original file descriptor except the CLOEXEC, so I think we don't even need the second fcntl.

Actually, I guess in case of receiving a different protection, we need to shm_open with the appropriate flags instead of using dup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.