[Webkit-unassigned] [Bug 131483] [EFL][WK2] Implement web notification.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 11 00:36:41 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=131483
Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #229033|review? |review-
Flag| |
--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2014-04-11 00:36:59 PST ---
(From update of attachment 229033)
View in context: https://bugs.webkit.org/attachment.cgi?id=229033&action=review
I think this patch needs to be reviewed for a long time because patch is too huge. :(
> Source/WebKit/efl/ChangeLog:3
> + [EFL][WK2] Implement web notification.
It would be good if you add [WK1] prefix as well.
> Source/WebKit2/UIProcess/API/efl/ewk_notification.h:58
> + * save yourself from cpu cycles and use eina_stringshare_ref()
I don't understand why this return type can be guaranteed by eina_stringshare. is the return char* protected by eina_stringshare_add() ?
> Source/WebKit2/UIProcess/API/efl/ewk_notification.h:61
> +EAPI const char *ewk_notification_title_get(const Ewk_Notification *notification);
Any unit test for this new APIs ?
> Source/WebKit2/UIProcess/API/efl/ewk_notification.h:128
> + * @return the security origin object or @c NULL if there is not security origin.
Do not use period at @return field.
> Source/WebKit2/UIProcess/API/efl/ewk_notification_permission_request.h:58
> +EAPI Ewk_Security_Origin *ewk_notification_permission_request_security_origin_get(const Ewk_Notification_Permission_Request *permissionRequest);
Any unit test for this new APIs ?
permissionRequest -> permission_request
> Source/WebKit2/UIProcess/API/efl/ewk_notification_permission_request.h:66
> +EAPI void ewk_notification_permission_request_allowed_set(Ewk_Notification_Permission_Request *permissionRequest, Eina_Bool allow);
ditto.
> Source/WebKit2/UIProcess/efl/NotificationProvider.h:26
> +#ifndef NotificationProvider_h
EFL port has used *Efl* post fix. Please use NotificaitonProviderEfl_h for file name as well.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list