[Webkit-unassigned] [Bug 130570] Stylechecker: False positive on inline asm code.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 8 09:41:43 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=130570
Csaba Osztrogonác <ossy at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #228838|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #8 from Csaba Osztrogonác <ossy at webkit.org> 2014-04-08 09:42:03 PST ---
(From update of attachment 228838)
View in context: https://bugs.webkit.org/attachment.cgi?id=228838&action=review
Now it looks much better, r=me.
> Tools/Scripts/webkitpy/style/checkers/cpp.py:2021
> - if search(r'^(?P<indentation>\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?)*\:)([^\:]|\Z)[^;]*$', line):
> + is_list_start = search(r'^(?P<indentation>\s*)((explicit\s+)?[^(\s|\?)]+\([^\?]*\)\s?\:|^(\s|\?)*\:)([^\:]|\Z)[^;]*$', line)
> + if is_list_start:
just a nit: do we really need this change? I don't think so.
Please change it back before landing.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list