[Webkit-unassigned] [Bug 130570] Stylechecker: False positive on inline asm code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 02:42:59 PDT 2014


--- Comment #4 from Peter Gal <galpeter at inf.u-szeged.hu>  2014-04-08 02:43:19 PST ---
(From update of attachment 228822)
View in context: https://bugs.webkit.org/attachment.cgi?id=228822&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:3671
> +        super(_InlineASMState, self).__init__()

This is still present.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:3675
> +        if match(r'\s*asm\s+(volatile){0,1}\(', line):

Why use {0,1} here? why not a simple '?' ? That would achieve the same and a bit more descriptive on what we want.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list