[Webkit-unassigned] [Bug 131260] [WK2] Fix unused parameter compile warning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131260





--- Comment #8 from Darin Adler <darin at apple.com>  2014-04-06 10:37:15 PST ---
(From update of attachment 228671)
View in context: https://bugs.webkit.org/attachment.cgi?id=228671&action=review

> Source/WebKit2/UIProcess/API/APIDownloadClient.h:63
> +    virtual void didReceiveData(WebKit::WebContext*, WebKit::DownloadProxy*, uint64_t length) { UNUSED_PARAM(length); }
> +    virtual bool shouldDecodeSourceDataOfMIMEType(WebKit::WebContext*, WebKit::DownloadProxy*, const WTF::String& mimeType)
> +    {
> +        UNUSED_PARAM(mimeType);
> +        return true;
> +    }
> +    virtual WTF::String decideDestinationWithSuggestedFilename(WebKit::WebContext*, WebKit::DownloadProxy*, const WTF::String& filename, bool& allowOverwrite)
> +    {
> +        UNUSED_PARAM(filename);
> +        UNUSED_PARAM(allowOverwrite);
> +        return { };
> +    }
> +    virtual void didCreateDestination(WebKit::WebContext*, WebKit::DownloadProxy*, const WTF::String& path) { UNUSED_PARAM(path); }

This is not what we want. We should just remove the argument names, not use UNUSED_PARAM and not reformat the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.