[Webkit-unassigned] [Bug 131237] Use preallocated stack reference to store adjacentBacktrackingStart

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131237


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228614|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Benjamin Poulain <benjamin at webkit.org>  2014-04-04 15:12:55 PST ---
(From update of attachment 228614)
View in context: https://bugs.webkit.org/attachment.cgi?id=228614&action=review

Everything looks correct to me.  CQ- because of two nitpicks.

> Source/WebCore/cssjit/SelectorCompiler.cpp:210
> +    bool m_needsAdjacentBacktrackingStart : 1;

You should not use a bit field here.

I would put the field just after m_selectorFragments since it is related to a global state of code generation.

> Source/WebCore/cssjit/StackAllocator.h:63
> +    StackReference push()

The name push() is a bit misleading. I think allocate() or allocateUninitialized() would be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.