[Webkit-unassigned] [Bug 131235] Keep track of filtered active attribute/uniform indices per shader program

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 4 13:18:09 PDT 2014


--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2014-04-04 13:18:27 PST ---
(From update of attachment 228613)
View in context: https://bugs.webkit.org/attachment.cgi?id=228613&action=review

Looks good. I think it could be more efficient if we could avoid the double 'find' operation in cases where it is found the first time.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:726
> +    const auto& result = m_shaderProgramSymbolCountMap.find(program);

Aren't we performing the 'find' twice every time? Maybe this could precede the test for end, and only do the lookup once.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:772
> +    const auto& result = m_shaderProgramSymbolCountMap.find(program);

Ditto regarding double-lookup.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list