[Webkit-unassigned] [Bug 131050] Web Inspector: Provide a way for JSContext console to log to system console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131050


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228546|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #9 from Timothy Hatcher <timothy at apple.com>  2014-04-04 12:26:56 PST ---
(From update of attachment 228546)
View in context: https://bugs.webkit.org/attachment.cgi?id=228546&action=review

> Source/JavaScriptCore/inspector/JSConsoleClient.cpp:75
> +    static std::once_flag initializeLogging;
> +    std::call_once(initializeLogging, []{
> +        JSConsoleClient::initializeLogToSystemConsole();
> +    });

This makes the default behave differently than the WebKit2 equivalent setting. It can only be changed between executions, not while the app is running. That seems fine, but it might be limiting if an app needed to change it at runtime (like with a command line flag or checkbox.) The solution would require always calling CFPreferencesGetAppBooleanValue, or exposing a JSC API to change it at runtime. We can cross that bridge when needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.