[Webkit-unassigned] [Bug 131211] [CSSRegions] Region's behaviour not updated when becoming valid from invalid

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131211


Andrei Bucur <abucur at adobe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228579|review?                     |review+
               Flag|                            |




--- Comment #2 from Andrei Bucur <abucur at adobe.com>  2014-04-04 00:19:07 PST ---
(From update of attachment 228579)
View in context: https://bugs.webkit.org/attachment.cgi?id=228579&action=review

r=me

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:80
>      // If the region is not attached to any thread, there is no need to check

You should consider removing this comment.

> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:-511
> -    if (documentBeingDestroyed() || !m_flowThread)

Let's make a patch that removes the m_flowThread nullification as well. The isValid() check should be enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.