[Webkit-unassigned] [Bug 131203] Crash in plugin process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131203


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228573|review?                     |review+
               Flag|                            |




--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2014-04-03 19:04:43 PST ---
(From update of attachment 228573)
r=me

You should explain in your ChangeLog that the old code crashed because it the C++ scope would delete its pluginController before the call to pluginDidBecomeHidden.

Would it be better for this function to take a pluginInstanceID argument, instead of a raw (dangerous) PluginControllerProxy pointer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.