[Webkit-unassigned] [Bug 131153] [CSS Blending] Add compositing reason for isolation in RenderLayerCompositor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131153


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228532|review?                     |review+
               Flag|                            |




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2014-04-03 14:15:42 PST ---
(From update of attachment 228532)
View in context: https://bugs.webkit.org/attachment.cgi?id=228532&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js:436
> +        if (compositingReasons.isolatesCompositedBlendingDescendants)
> +            addReason(WebInspector.UIString("Element isolates composited descendants having CSS blending applied"));

Very interesting! The patch looks good, As a user facing feature, I'd want to get a little more information on what isolation is so that maybe we can improve the UI String. Right now it sounds fine.

Is "-webkit-isolation" with children having blending the only way to get this state? Is just -webkit-isolation enough?

Note some of the other reasons include the CSS property, so it might be useful here to include "-webkit-isolation".

> LayoutTests/inspector-protocol/layers/layers-blending-compositing-reasons.html:114
> +            if (messageObject.hasOwnProperty("error")) {

Nit: This can be shorted to:

    InspectorTest.checkForError(messageObject);

Which will print a fail message, complete the test, and short circuit by throwing an exception.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.