[Webkit-unassigned] [Bug 130834] Move UseJSC.cmake back to CMakeLists.txt
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 3 04:22:22 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=130834
Csaba Osztrogonác <ossy at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #227943|review? |review-
Flag| |
--- Comment #3 from Csaba Osztrogonác <ossy at webkit.org> 2014-04-03 04:22:36 PST ---
(From update of attachment 227943)
View in context: https://bugs.webkit.org/attachment.cgi?id=227943&action=review
I agree with this change, but r- now due to some minor things.
> Source/WebCore/CMakeLists.txt:2838
> + list(APPEND WebCore_SOURCES
> + bindings/js/JSCustomSQLStatementErrorCallback.cpp
> + bindings/js/JSSQLResultSetRowListCustom.cpp
> + bindings/js/JSSQLTransactionCustom.cpp
> + bindings/js/JSSQLTransactionSyncCustom.cpp
> + )
Please move them after Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp - few lines above.
> Source/WebCore/CMakeLists.txt:2875
> + bindings/js/JSWebGLRenderingContextCustom.cpp
We don't need one more APPEND, just add it before html/canvas/ANGLEInstancedArrays.cpp.
> Source/WebCore/CMakeLists.txt:2976
> + bindings/js/JSAudioTrackCustom.cpp
> + bindings/js/JSAudioTrackListCustom.cpp
> + bindings/js/JSTextTrackCueCustom.cpp
> + bindings/js/JSTextTrackCustom.cpp
> + bindings/js/JSTextTrackListCustom.cpp
> + bindings/js/JSTrackCustom.cpp
> + bindings/js/JSTrackEventCustom.cpp
> + bindings/js/JSVideoTrackCustom.cpp
> + bindings/js/JSVideoTrackListCustom.cpp
> + )
> +
> + list(APPEND WebCore_SOURCES
ditto, just add them before html/track/AudioTrack.cpp
> Source/WebCore/CMakeLists.txt:-3193
> -
> -include(${WEBCORE_DIR}/UseJSC.cmake)
> -
I prefer moving the line 285 - end part of UseJSC.cmake
to this place instead of splitting into several pieces.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list