[Webkit-unassigned] [Bug 131093] Move removeEquivalentProperties functions to EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131093





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2014-04-03 02:01:04 PST ---
(From update of attachment 228370)
View in context: https://bugs.webkit.org/attachment.cgi?id=228370&action=review

>> Source/WebCore/editing/EditingStyle.cpp:1576
>> +    RefPtr<EditingStyle> style = EditingStyle::create()->copy();
>> +    style->removeEquivalentProperties(baseStyle);
> 
> Where's this data supposed to go?

This code doesn't make any sense.  We should be removing baseStyle properties from result here
but the new code is a no-op because there's nothing to be removed from an empty EditingStyle.

> Source/WebCore/editing/EditingStyle.h:149
> +    void removeEquivalentProperties(const StyleProperties*);
> +    void removeEquivalentProperties(const ComputedStyleExtractor*);
> +

These functions should be private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.