[Webkit-unassigned] [Bug 130308] bad values from HTMLImageElement x and y attributes (CSSOM-View)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130308


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228391|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2014-04-02 09:54:31 PST ---
(From update of attachment 228391)
View in context: https://bugs.webkit.org/attachment.cgi?id=228391&action=review

The right basic idea here, but incorrect implementation.

> Source/WebCore/html/HTMLImageElement.cpp:382
> +    document().updateStyleIfNeeded();

The correct call to make here is:

    document().updateLayoutIgnorePendingStylesheets();

See Element::offsetLeft for an example of how to do it.

> Source/WebCore/html/HTMLImageElement.cpp:389
> +    if (renderer->needsLayout())
> +        document().updateLayout();

This is not needed. Please don’t add it.

> Source/WebCore/html/HTMLImageElement.cpp:397
> +    document().updateStyleIfNeeded();

Same comment as above.

> Source/WebCore/html/HTMLImageElement.cpp:404
> +    if (renderer->needsLayout())
> +        document().updateLayout();

This is not needed. Please don’t add it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.