[Webkit-unassigned] [Bug 103473] [CSS Grid Layout] Make sure grid element's shrink-to-fit behavior is correct

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 04:19:20 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=103473





--- Comment #10 from Sergio Villar Senin <svillar at igalia.com>  2014-04-02 04:19:38 PST ---
(From update of attachment 228381)
View in context: https://bugs.webkit.org/attachment.cgi?id=228381&action=review

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit-expected.html:7
> +

Don't need to define & use this.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit-expected.html:10
> +    width: 100%;

Don't need to define width.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:52
> +}

See the comment bellow about grid items.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:62
> +  <div class="four"></div>

Do we need grid items?

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:69
> +  <div class="four"></div>

Ditto.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:76
> +  <div class="four"></div>

Ditto.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:83
> +  <div class="four"></div>

Ditto.

> LayoutTests/fast/css-grid-layout/grid-element-shrink-to-fit.html:86
> +

Remove empty lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list