[Webkit-unassigned] [Bug 130391] [EFL] [WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130391


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228294|review?                     |review-
               Flag|                            |




--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2014-04-01 17:58:50 PST ---
(From update of attachment 228294)
View in context: https://bugs.webkit.org/attachment.cgi?id=228294&action=review

> Source/WebKit2/ChangeLog:7
> +

Missing patch description.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:583
> +EAPI Eina_Bool ewk_view_page_zoom_set(Evas_Object *o, double zoomFactor);

Wrong EFL parameter style. Look at https://trac.webkit.org/wiki/EFLWebKitCodingStyle

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1102
> ++

Remove +

> Tools/ChangeLog:7
> +

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.