[Webkit-unassigned] [Bug 131006] std::bind not compiling with Visual Studio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131006


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228238|review?                     |review-
               Flag|                            |




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-04-01 00:28:12 PST ---
(From update of attachment 228238)
View in context: https://bugs.webkit.org/attachment.cgi?id=228238&action=review

We use the versions with the bool function to decide whether to use g_idle or g_timeout, if you remove the versions receiving a bool function it's impossible to implement a repeating source. I guess the problem with visual studio is that the compiler doesn't know which one to use, so a possible workaround would be to add a cast in the callers, see the discussion here: https://bugs.webkit.org/show_bug.cgi?id=130027#c15

> Source/WTF/ChangeLog:4
> +        [WinCairo] Build fix after r166496.
> +        https://bugs.webkit.org/show_bug.cgi?id=131006

Removing the code that doesn't build for you is not a build fix :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.