[Webkit-unassigned] [Bug 108987] "Select all" doesn't select anything when a contenteditable="false" element is present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 20:31:19 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=108987





--- Comment #57 from Ryosuke Niwa <rniwa at webkit.org>  2013-09-30 20:30:15 PST ---
(From update of attachment 212894)
View in context: https://bugs.webkit.org/attachment.cgi?id=212894&action=review

> Source/WebCore/ChangeLog:9
> +        Test: editing/selection/select-all-with-div-noneditable.html
> +

This line should appear after the long description but before the list of files and function names.

> Source/WebCore/ChangeLog:16
> +        But editableRootPosition, highestRootEditablePosition and
> +        rootEditablePosition return 0 for nonediatble element due to which
> +        the check for position to be under same highestRootEditable element
> +        fails.

This doesn't justify the change. Why should that matter at all?  It appears to be that this is a bug in VisibleSelection, not PositionIterator.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list