[Webkit-unassigned] [Bug 122115] Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 13:48:26 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122115





--- Comment #2 from Daniel Bates <dbates at webkit.org>  2013-09-30 13:47:23 PST ---
(From update of attachment 213021)
View in context: https://bugs.webkit.org/attachment.cgi?id=213021&action=review

> Source/WebCore/ChangeLog:7
> +        passing a native image.  If this image is added to memory cache, we shouldn't attempt to destroy

Nit: "added to memory cache" => "added to the memory cache"

> Source/WebCore/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).

Nit: This line should come after the bug URL.

> Source/WebCore/ChangeLog:13
> +        No new tests for now. Currently there is no code patch to add an BitmapImage created by native image
> +        to memory cache, we will add this in future.

The second sentence doesn't read well. Maybe:

Currently there isn't a code path to add to the memory cache a BitmapImage that was created by adopting a native image. We'll add such a code path in a subsequent patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list