[Webkit-unassigned] [Bug 122069] WinLauncher should be able to open cross-domain links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122069





--- Comment #6 from Alex Christensen <alex.christensen at flexsim.com>  2013-09-30 08:19:53 PST ---
(In reply to comment #5)
> (From update of attachment 212911 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212911&action=review
> 
> > Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:204
> > +    request.adoptRef(WebMutableURLRequest::createInstance(ResourceRequest(navigationAction.url())));
> 
> Can this not be written in our usual one-line style?
COMPtr.h doesn't seem to have an adoptRef function.  I could write one if it doesn't already exist somewhere else.

> This looks okay, but why do we spawn a new process to view a web page? We don't spawn a new WinLauncher to show the Web Inspector, can't we work the same way here?
I tried a single-process implementation based on the one in DumpRenderTree, but it was much more complicated, and I had problems where closing child windows killed the whole process.  Maybe this can be worked around, but this is the simplest solution.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.