[Webkit-unassigned] [Bug 122069] WinLauncher should be able to open cross-domain links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122069





--- Comment #5 from Brent Fulgham <bfulgham at webkit.org>  2013-09-30 00:03:41 PST ---
(From update of attachment 212911)
View in context: https://bugs.webkit.org/attachment.cgi?id=212911&action=review

> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:204
> +    request.adoptRef(WebMutableURLRequest::createInstance(ResourceRequest(navigationAction.url())));

Can this not be written in our usual one-line style?

> Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:542
> +    request.adoptRef(WebMutableURLRequest::createInstance(ResourceRequest(navigationAction.url())));

Ditto:

> Tools/WinLauncher/PrintWebUIDelegate.cpp:47
> +    DWORD length = GetModuleFileName(GetModuleHandle(0), buffer, ARRAYSIZE(buffer));

Please prefix WinAPI calls with '::'

> Tools/WinLauncher/PrintWebUIDelegate.cpp:51
> +    BSTR url;

If you use a _bstr_t it will clean up after itself.

> Tools/WinLauncher/PrintWebUIDelegate.cpp:63
> +        return E_FAIL;

This looks okay, but why do we spawn a new process to view a web page? We don't spawn a new WinLauncher to show the Web Inspector, can't we work the same way here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.