[Webkit-unassigned] [Bug 122062] Web Inspector: content view in back/forward list multiple times won't restore earlier positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122062





--- Comment #6 from Timothy Hatcher <timothy at apple.com>  2013-09-28 09:00:26 PST ---
(In reply to comment #3)
> I extracted BackForwardEntry in the hopes that more functionality would be moved into there, such as taking different restore actions based on ContentView subclass. I'm not sure if that would make this less coupled than the current version which stores an arbitrary callback.
> 
> In the next few patches, I want to merge BackForwardEntry with the cookies used for restoring across inspector close/opens.

Where is the BackForwardEntry patch?

Making ContentViewController aware of specific ContentView subclasses would be a layering violation. The callback makes sense with how it is used by the sidebar. I do worry there are places where a resource content view will be shown that does not go through the sidebar and it will miss out of restore functionality. Adding a generic content view interface that each view can implement to provide a cookie and restore would be another approach. But getting the cookie from the contentView up-front to compare before it is shown would be a challenge.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.