[Webkit-unassigned] [Bug 122005] Removing noisy compilation warnings after r156341

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122005


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212787|review?                     |review-
               Flag|                            |




--- Comment #2 from Anders Carlsson <andersca at apple.com>  2013-09-27 10:11:35 PST ---
(From update of attachment 212787)
View in context: https://bugs.webkit.org/attachment.cgi?id=212787&action=review

> Source/WebKit2/Platform/CoreIPC/Arguments.h:59
>  
>  template<typename... Elements>
>  struct TupleCoder<0, Elements...> {
> -    static void encode(ArgumentEncoder& encoder, const std::tuple<Elements...>& tuple)
> +    static void encode(ArgumentEncoder&, const std::tuple<Elements...>&)
>      {
>      }
>  
> -    static bool decode(ArgumentDecoder& decoder, std::tuple<Elements...>& tuple)
> +    static bool decode(ArgumentDecoder&, std::tuple<Elements...>&)
>      {
>          return true;
>      }

This was landed in a separate patch.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1290
> +#if !ENABLE(NETSCAPE_PLUGIN_API)
> +    UNUSED_PARAM(pluginElement);
> +#endif

I prefer having the code be:

#if ENABLE
#else
#endif

Same goes for all the !ENABLE #ifs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.