[Webkit-unassigned] [Bug 121959] [ATK] Normalize checks in entry points for DRT and WKTR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121959





--- Comment #3 from chris fleizach <cfleizach at apple.com>  2013-09-26 09:25:43 PST ---
(From update of attachment 212717)
View in context: https://bugs.webkit.org/attachment.cgi?id=212717&action=review

> Tools/ChangeLog:5
> +

can you add a description of what and why this patch is needed

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:814
> +    if (!ATK_IS_VALUE(m_element.get()))

I don't know much about this ATK_IS_* API, but it does seem strange to me that an m_element could be
ATK_IS_VALUE or ATK_IS_OBJECT

The difference between ATK_IS_OBJECT and ATK_IS_COMPONENT is also pretty nebulous it seems.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1079
>      if (!ATK_IS_ACTION(m_element.get()))

ditto about the naming. maybe this is right, but it does seem strange that you can check that the element is ATK_IS_ACTION

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.