[Webkit-unassigned] [Bug 50619] [GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50619





--- Comment #36 from Simon Pena <simon.pena at samsung.com>  2013-09-26 01:28:30 PST ---
(From update of attachment 212584)
View in context: https://bugs.webkit.org/attachment.cgi?id=212584&action=review

Please find a couple of comments below. I am not an expert, so this is not even an informal review, just an effort on my side to understand the patch :)

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:323
> +        cairo_matrix_translate(&fontMatrix, 0.0, 1.0);

Could you explain why this makes the translation in the y-axis, while in FontPlatformData::setOrientation you translate in the x-axis?

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:363
> +    uint32_t tag = (table >> 24) | ((table >> 8) & 0xff00) | ((table & 0xff00) << 8) | ((table & 0xff) << 24);

I am not sure, but maybe you could try to use http://www.freetype.org/freetype2/docs/reference/ft2-basic_types.html#FT_MAKE_TAG for this, and it would increase readability.

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:388
> +    cairo_matrix_t ctm;

Maybe you could use a more verbose name here?

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:408
> +

This is what I meant: here you do the translation on the other x-axis.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.