[Webkit-unassigned] [Bug 121558] [ATK] Protect entry points in the ATK wrapper against outdated render trees

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 25 11:17:38 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121558





--- Comment #20 from chris fleizach <cfleizach at apple.com>  2013-09-25 11:16:37 PST ---
(From update of attachment 212582)
View in context: https://bugs.webkit.org/attachment.cgi?id=212582&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:38
> +#define returnIfObjectIsInvalid(webkitAccessible) G_STMT_START { \

I would just name this (webkitAccessible) "object", since the name of the macro is "returnIfObjectIs..."

> Source/WebCore/accessibility/atk/WebKitAccessibleUtil.h:44
> +            g_log(G_LOG_DOMAIN, \

do you think you need to log this event? it doesn't happen often, but it does seem like a valid use case to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list