[Webkit-unassigned] [Bug 121882] Clean up some uses of first/lastChildSlow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121882


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212525|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-09-24 17:31:28 PST ---
(From update of attachment 212525)
View in context: https://bugs.webkit.org/attachment.cgi?id=212525&action=review

r=me

> Source/WebCore/dom/Position.cpp:857
> +    for (RenderObject *o = renderer.firstChild(); o && o != stop; o = o->nextInPreOrder())

* placement

> Source/WebCore/rendering/RenderBlock.cpp:1074
> +    if (anonymousBlock->continuation() || anonymousBlock->beingDestroyed())
>          return false;

We should postpone the continuation() check if possible, since it does a hash lookup.

> Source/WebCore/rendering/RenderBlock.cpp:5956
> -    RenderObject* firstLetterBlock = findFirstLetterBlock(this);
> +    RenderElement* firstLetterBlock = findFirstLetterBlock(this);

I think we can make findFirstLetterBlock() return RenderBlock*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.