[Webkit-unassigned] [Bug 121829] optimize js splice

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121829





--- Comment #3 from Darin Adler <darin at apple.com>  2013-09-24 09:16:53 PST ---
(From update of attachment 212443)
View in context: https://bugs.webkit.org/attachment.cgi?id=212443&action=review

> runtime/JSArray.h:100
> -        return shiftCountWithAnyIndexingType(exec, startIndex, count);
> +        if (!shiftCountForShift(exec, startIndex, count)) 
> +            return shiftCountWithAnyIndexingType(exec, startIndex, count);
> +        
> +
> +        return true;

For what it’s worth, the much clearer to write this is:

    return shiftCountForShift(exec, startIndex, count) || shiftCountWithAnyIndexingType(exec, startIndex, count);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.