[Webkit-unassigned] [Bug 120772] [GTK] [Meta] GtkActions and Stock Items are deprecated in gtk+ 3.10

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120772





--- Comment #9 from Zan Dobersek <zandobersek at gmail.com>  2013-09-24 09:16:30 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > If the problem is that there are compile warnings, I wouldn't worry too much. We don't plan to bump GTK+ requirements, and I wouldn't spend time porting to new API either (I'm not even sure there's a replacement in current glib/GTK+ API for out uses cases), if the code is going to be full of #ifdefs. We expose GtkAction in the ContextMenu API and it works pretty well, so I would keep GtkAction and stock icons until we bump the requirements to GTK 4.0.
> 
> Its not that there are just compile warning, building WebKit with debug symbols fails: 
> $ ./autogen.sh --prefix=/opt/gnome3 --libdir=/opt/gnome3/lib64 --enable-debug
> 
> Source/WebKit/gtk/webkit/webkitwebview.cpp:1309:53: error: 'GTK_STOCK_CANCEL' was not declared in this scope
> Source/WebKit/gtk/webkit/webkitwebview.cpp:1310:53: error: 'GTK_STOCK_OPEN' was not declared in this scope

I removed the disabling of deprecated API under debug builds in r155509.
http://trac.webkit.org/changeset/155509

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.