[Webkit-unassigned] [Bug 121674] [ATK] Missing WTR AccessibilityController::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121674


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212173|review?                     |review-
               Flag|                            |




--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-09-24 05:43:28 PST ---
(From update of attachment 212173)
View in context: https://bugs.webkit.org/attachment.cgi?id=212173&action=review

The patch is great, just r- because of the EFL bit, which I think it's better to leave it to the EFL guys (so they can test it first)

> Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:100
> +#if !PLATFORM(GTK) && !PLATFORM(EFL) && !PLATFORM(MAC)

Unless you are sure about this working on EFL, I think it's probably better to live the EFL check out of this patch and let the EFL guys (Krzysztof) know about the change with a comment in bug 112003, where they track the issue about the same failing test, buyt for EFL-WK2

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.