[Webkit-unassigned] [Bug 120058] Add an MathMLSelectElement class to implement <maction> and <semantics>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120058


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212371|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #23 from Darin Adler <darin at apple.com>  2013-09-23 23:58:35 PST ---
(From update of attachment 212371)
View in context: https://bugs.webkit.org/attachment.cgi?id=212371&action=review

> Source/WebCore/mathml/MathMLSelectElement.cpp:56
> +    return (child->isElementNode() && child == m_selectedChild);

There is no need for the child->isElementNode() check. This line should read:

    return child == m_selectedChild;

No parentheses and no isElementNode check.

> Source/WebCore/mathml/MathMLSelectElement.cpp:107
> +    if (m_selectedChild && m_selectedChild->renderer())
> +        Style::detachRenderTree(*m_selectedChild);

We will need to do the further research. Setting an object's style to "display: none" results in the render object being destroyed, and I see no reason why this change couldn't also do the same thing. Just requires some research to figure out exactly how that works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.