[Webkit-unassigned] [Bug 120058] Add an MathMLSelectElement class to implement <maction> and <semantics>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120058





--- Comment #21 from Frédéric Wang <fred.wang at free.fr>  2013-09-23 10:36:42 PST ---
(In reply to comment #20)
> (From update of attachment 212337 [details])
> > Source/WebCore/mathml/MathMLSelectElement.cpp:86
> > +        if (actiontype != "tooltip" && actiontype != "statusline") {
> 
> Do these need to be case sensitive? Does the test case check that they should be case sensitive? I guess I asked this before.

Yes, I added a test to check that they are case sensitive.

> > Source/WebCore/mathml/MathMLSelectElement.cpp:107
> > +    if (m_selectedChild && m_selectedChild->renderer())
> > +        Style::detachRenderTree(*m_selectedChild);
> 
> This seems surprisingly manual and low level. Explicitly deleting the renderer like this is surprising. I’d normally expect this to be done during the later style recalculation process rather than explicitly and immediately.

I think when I initially wrote the first patch, not detaching the render tree made the former selected child still visible. I took inspiration from the implementation of the SVG <switch> element but that one does not seem to work very well either (see bug 74749) so that didn't help. How can I ask the style recalculation process remove this render tree? Should I add some kind of "mark dirty" to the renderer or something?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.