[Webkit-unassigned] [Bug 111986] [EFL] accessibility/aria-invalid is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=111986





--- Comment #5 from Krzysztof Czech <k.czech at samsung.com>  2013-09-23 04:13:41 PST ---
 > > Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:131
> > +#elif PLATFORM(EFL) && HAVE(ACCESSIBILITY)
> 
> The whole content of this file is wrapper inside an HAVE(ACCESSIBILITY) guard, so you don't need to add it explicitly here.
> 
Indeed, sorry, I did not catch this.
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:116
> > +#if PLATFORM(GTK) || (PLATFORM(EFL) && HAVE(ACCESSIBILITY))
> 
> In this case is different because this file is not guarded at all as the other ones.
> 
> Perhaps we should do it here too? After all, this file does not make much sense at all if you don't have accessibility enabled, does it? :)

Yes, you're right, we should have this guard. Those are specific accessibility bits.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.