[Webkit-unassigned] [Bug 29241] Hiding a focused element should unfocus it and fire a blur event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29241





--- Comment #25 from Darin Adler <darin at apple.com>  2013-09-21 21:07:56 PST ---
(From update of attachment 212271)
View in context: https://bugs.webkit.org/attachment.cgi?id=212271&action=review

>>> Source/WebCore/dom/Document.cpp:4719
>>> +        return;
>> 
>> This may be sufficient to make the assertion go away, but it’s a fully correct fix. It’s not safe to call setFocusedElement until layout is done, not just for one element, but for the entire render tree.
>> 
>> Instead, this just checks what the assertion will check, which may seem mechanically correct, but is wrong.
> 
> it’s *not* a fully correct fix

A correct fix would be something more like this:

    if (FrameView* view = this->view()) {
        if (view->needsLayout())
            return;
    }

And also, we have to add code to make sure that this “reset hidden focus element logic” runs when the layout is done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.