[Webkit-unassigned] [Bug 121711] Handle panning gestures messages properly on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121711


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212245|review?                     |review+
               Flag|                            |




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org>  2013-09-20 17:17:12 PST ---
(From update of attachment 212245)
View in context: https://bugs.webkit.org/attachment.cgi?id=212245&action=review

Looks great!  We might want to add a FIXME for Right-to-left languages if that's something we are likely to encounter for scroll bar support.

> Source/WebKit/win/WebView.cpp:1611
> +            || (view->horizontalScrollbar() && (gestureBeginPoint.y > (webViewRect.bottom - view->horizontalScrollbar()->theme()->scrollbarThickness())));  

This might not be right for a right-to-left environment.

> Source/WebKit/win/WebView.cpp:1640
> +        // Disable single-fingered horizontal panning only if the target node text.

... target node *is* text?

> Source/WebKit/win/WebView.cpp:1741
> +        UpdatePanningFeedbackPtr()(m_viewWindow, xpan, ypan, gi.dwFlags & GF_INERTIA);

Nice!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.