[Webkit-unassigned] [Bug 121671] Make RenderObject::parent() return RenderElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121671





--- Comment #4 from Andreas Kling <akling at apple.com>  2013-09-20 04:13:10 PST ---
(From update of attachment 212147)
View in context: https://bugs.webkit.org/attachment.cgi?id=212147&action=review

> Source/WebCore/rendering/RenderBlock.cpp:1791
> +    RenderBlock* nextSiblingBlock = toRenderBlock(curr);

Why not make it a RenderBlock&

> Source/WebCore/rendering/RenderElement.cpp:142
> +    RenderObjectChildList* children = this->children();
> +    ASSERT(children);
> +    if (!children)
> +        return;

Wish 'children' would be a RenderObjectChildList& after the null check.

> Source/WebCore/rendering/RenderElement.cpp:196
> +    RenderObjectChildList* children = this->children();
> +    ASSERT(children);
> +    if (!children)
> +        return;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.