[Webkit-unassigned] [Bug 120421] [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421





--- Comment #19 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-09-20 03:20:05 PST ---
(From update of attachment 211567)
View in context: https://bugs.webkit.org/attachment.cgi?id=211567&action=review

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:93
>> +            notificationName = "AXInvalidStatusChanged";
> 
> I think we should also cover the other cases with this patch that are managed by DRT already: CheckedStateChanged, AXLayoutComplete, AXFocusedUIElementChanged and AXValueChanged.
> 
> Potentially, that change might help us remove more tests from TestExpectations, or at least help us get closer to that (in case there were additional issues pending to be resolved)

Sure, good point. I'll add the other cases.

>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:577
>> +
> 
> This bit is not actually related to this bug, since it just adds the mapping in WKTR to read the exposed value for aria-invalid and has nothing to do with the notifications stuff.
> 
> Maybe file a new bug just for it depending on this bug, and move the removal of aria-invalid test from TestExpectations file there?

Ok. I've raised another bug for it (bug 121668)

>> LayoutTests/platform/gtk-wk2/TestExpectations:-504
>> -
> 
> As mentioned above, this could be moved to a separate bug if we file one for the aria-invalid mapping thing

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.