[Webkit-unassigned] [Bug 120421] [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120421


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211567|review?                     |review-
               Flag|                            |




--- Comment #18 from Mario Sanchez Prada <mario at webkit.org>  2013-09-20 01:45:17 PST ---
(From update of attachment 211567)
View in context: https://bugs.webkit.org/attachment.cgi?id=211567&action=review

Curiously enough, I found a couple of things now that I thing it would be great to fix/improve before landing the patch, which is already great.

Setting r- because of those. See comments below...

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:93
> +        if (!g_strcmp0(g_value_get_string(&paramValues[1]), "invalid-entry"))
> +            notificationName = "AXInvalidStatusChanged";

I think we should also cover the other cases with this patch that are managed by DRT already: CheckedStateChanged, AXLayoutComplete, AXFocusedUIElementChanged and AXValueChanged.

Potentially, that change might help us remove more tests from TestExpectations, or at least help us get closer to that (in case there were additional issues pending to be resolved)

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:577
> +
> +    // In case of 'aria-invalid' when the attribute empty or has "false" for ATK
> +    // according to http://www.w3.org/WAI/PF/aria-implementation/#mapping attribute
> +    // is not mapped but layout tests will expect 'false'.
> +    if (attributeValue.isEmpty() && atkAttributeName == "aria-invalid")
> +        return JSStringCreateWithUTF8CString("false");
> +

This bit is not actually related to this bug, since it just adds the mapping in WKTR to read the exposed value for aria-invalid and has nothing to do with the notifications stuff.

Maybe file a new bug just for it depending on this bug, and move the removal of aria-invalid test from TestExpectations file there?

> LayoutTests/platform/gtk-wk2/TestExpectations:-504
> -# [GTK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
> -webkit.org/b/120421 accessibility/aria-invalid.html [ Timeout ]
> -

As mentioned above, this could be moved to a separate bug if we file one for the aria-invalid mapping thing

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.