[Webkit-unassigned] [Bug 121638] Add covariant RenderElement* ContainerNode::renderer()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 20 01:24:49 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121638





--- Comment #12 from Antti Koivisto <koivisto at iki.fi>  2013-09-20 01:23:54 PST ---
(In reply to comment #2)
> (From update of attachment 212096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212096&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Add covariant RenderElement* ContainerNode::renderer()
> 
> ContainerNode -> RenderElement -> Element
> This is pretty weird-looking. :)

Moved it to 

RenderElement* Element::renderer()

which makes more sense. While all ContainerNode renderers are RenderElements it makes more semantic sense to have it in Element. ContainerNode is not that popular of a type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list