[Webkit-unassigned] [Bug 121592] Fixed img src URLS with multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121592





--- Comment #5 from Yoav Weiss <yoav at yoav.ws>  2013-09-19 09:48:27 PST ---
(In reply to comment #4)
> (From update of attachment 212039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212039&action=review
> 
> Some drive by comments below. I don't now enough about srcset to review.
> 
> > Source/WebCore/html/parser/HTMLParserIdioms.cpp:408
> > +        image.imageURL = decodeURLEscapeSequences(srcAttribute);
> 
> Is decodeURLEscapeSequences needed? Generally, relative URLs from HTML attributes should not be touched in any way other than completeURL().

It is not needed, and causes harm as seen at https://bugs.webkit.org/show_bug.cgi?id=121609
If I'd seen it earlier, I would have merged the 2 into a single issue.
I can still extend this one to include both patches if necessary.

> 
> > LayoutTests/ChangeLog:12
> > +        * fast/loader/resources/image  space.png: Added.
> 
> It woud be nice if the image wasn't pink/red. Having any red in test results implies a failure, see e.g. <http://www.w3.org/Style/CSS/Test/guidelines.html>.

I wasn't aware of that. I'll modify it.
> 
> > LayoutTests/fast/loader/image-src-multiple-space.html:8
> > +    if (window.testRunner) {
> > +        testRunner.dumpAsText();
> > +    }
> > +
> 
> This is unnecessary and should be removed, js-test-pre.js calls dumpAsText().
OK. Will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.