[Webkit-unassigned] [Bug 121592] Fixed img src URLS with multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121592





--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2013-09-19 09:25:33 PST ---
(From update of attachment 212039)
View in context: https://bugs.webkit.org/attachment.cgi?id=212039&action=review

Some drive by comments below. I don't now enough about srcset to review.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:408
> +        image.imageURL = decodeURLEscapeSequences(srcAttribute);

Is decodeURLEscapeSequences needed? Generally, relative URLs from HTML attributes should not be touched in any way other than completeURL().

> LayoutTests/ChangeLog:12
> +        * fast/loader/resources/image  space.png: Added.

It woud be nice if the image wasn't pink/red. Having any red in test results implies a failure, see e.g. <http://www.w3.org/Style/CSS/Test/guidelines.html>.

> LayoutTests/fast/loader/image-src-multiple-space.html:8
> +    if (window.testRunner) {
> +        testRunner.dumpAsText();
> +    }
> +

This is unnecessary and should be removed, js-test-pre.js calls dumpAsText().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.