[Webkit-unassigned] [Bug 121596] [CTTE] RenderText is always anonymous or associated with Text node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121596


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212043|review?                     |review+
               Flag|                            |




--- Comment #3 from Andreas Kling <akling at apple.com>  2013-09-19 03:22:00 PST ---
(From update of attachment 212043)
View in context: https://bugs.webkit.org/attachment.cgi?id=212043&action=review

> Source/WebCore/rendering/RenderCounter.h:50
> +    RenderCounter(const CounterContent&);

explicit

> Source/WebCore/rendering/RenderQuote.h:39
> +    RenderQuote(QuoteType);

explicit

> Source/WebCore/rendering/RenderText.cpp:166
> -    view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());
> +    if (textNode)
> +        view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());

This is so ugly. I wish we had alternate constructors for this kind of thing, so view() is always guaranteed to work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.