[Webkit-unassigned] [Bug 120668] [CSS Background] repeat: round should round the number of tiles to the nearest natural number

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120668





--- Comment #5 from Andrei Parvu <parvu at adobe.com>  2013-09-17 23:45:20 PST ---
(In reply to comment #4)
> (From update of attachment 211880 [details])
> I’d like to see test cases right on the boundary, demonstrating the rounding behavior. So things just below and just above the place where we round in two different directions. Something that would fail if we used the wrong rounding function.

Thanks for the comments, Darin!

Actually, the tests handle this: if we use ceil instead of round, mask-repeat-round-auto1.html, mask-repeat-round-auto2.html, mask-repeat-round-border.html and mask-repeat-round-content.html fail. If we use floor instead of round mask-repeat-round-padding.html fails.

Regarding the round function, we can use lroundf, which takes a float and also does the conversion to long - I'll upload a patch for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.