[Webkit-unassigned] [Bug 121485] [Win] TestWebKitAPI does not compile.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121485


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211895|review?, commit-queue?      |review+
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-09-17 19:31:22 PST ---
(From update of attachment 211895)
View in context: https://bugs.webkit.org/attachment.cgi?id=211895&action=review

I have a few questions, but I think this looks good.  I'll r+ it and trust that you'll adjust things if you need to :-)

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:44
> +    auto hbmp = ::CreateDIBSection(0, &bitmapInfo, DIB_RGB_COLORS, 0, 0, 0);

Does this need to be cleaned up somewhere? I can't tell (with a few seconds checking) whether we need to delete this GDI object.

Otherwise looks good to me.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:48
> +    if (bitmapImageTest) {

I would prefer an early exit, but this is fine.

> Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:53
> +        HBITMAP hBitmap = CreateBitmap(sz.width(), sz.height(), 1, 32, bits);

Does this bitmap need to be destroyed to be correct in our GDI/memory handling?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.