[Webkit-unassigned] [Bug 121477] [ATK] Expose aria-valuetext as an object attribute.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 17 06:50:05 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=121477


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211885|review?                     |review-
               Flag|                            |




--- Comment #7 from Mario Sanchez Prada <mario at webkit.org>  2013-09-17 06:49:11 PST ---
(From update of attachment 211885)
View in context: https://bugs.webkit.org/attachment.cgi?id=211885&action=review

(In reply to comment #4)
> [...]
> > I have just commented on that bug. If we get the correct API in place, will you please use that instead?
> Yes sure, as soon as we get the correct ATK API, I will use it instead.
> 
I've just reviewed the patch and, besides the things I pointed out below, I think the implementation in the wrapper is ok if we compare it to what W3C says now. However, I agree with joanie that we will need to re-do this anyway in terms of the new API in AtkValue as soon as it gets there, but for the time being I'd personally go with this.

Do you agree, Joanie?

Btw, giving r- because of the thing about sharing the tests and the missing implementation for DRT

> LayoutTests/ChangeLog:17
> +        * platform/efl/accessibility/aria-valuetext-expected.txt: Added.
> +        * platform/efl/accessibility/aria-valuetext-on-native-slider-expected.txt: Added.
> +        * platform/efl/accessibility/aria-valuetext-on-native-slider.html: Added.
> +        * platform/efl/accessibility/aria-valuetext.html: Added.
> +        * platform/gtk/accessibility/aria-valuetext-expected.txt: Added.
> +        * platform/gtk/accessibility/aria-valuetext-on-native-slider-expected.txt: Added.
> +        * platform/gtk/accessibility/aria-valuetext-on-native-slider.html: Added.
> +        * platform/gtk/accessibility/aria-valuetext.html: Added.

It looks to me like these 2 tests could be shared as cross-platform ones. Why not reusing the ones from the mac by moving them and adapting DRT & WKTR to provide the same output?

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:808
> +    String attributeValue = getAttributeSetValueForId(ATK_OBJECT(m_element.get()), "valuetext");

Here it might be a good place to prepend the "AXValueDescription: " string, so we can share the tests.

Btw, I don't see the change for DRT in this patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list