[Webkit-unassigned] [Bug 121458] Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121458





--- Comment #5 from Mike West <mkwst at chromium.org>  2013-09-16 23:28:43 PST ---
(In reply to comment #4)
> > I think that parser->isExecutingScript() may be giving a wrong result.
> 
> This function only tells you if parser is executing a script, not if a script is being executed for any other reason.

You're entirely correct; this code is broken as written. My apologies. :/

I plan to resolve it in Blink by distinguishing between console messages that relate to parsing, and those that don't. After a not-terribly-deep audit, it looks like SecurityMessageSource is the only MessageSource that refers both to parsing errors and non-parsing errors.

An initial attempt to separate those out is up at https://codereview.chromium.org/20890003/. I've abandoned that patch after discussion with pfeldman@, and I'd now like to just split SecurityMessageSource into two sources: ParsingSecurityMessageSource and NonparsingSecurityMessageSource (not with those names, of course :) ).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.